Fix a racecondition in unpacking proj-src #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unpacking the proj source code to the cargo registry cache can run into potential data races for concurrent builds. This can be fixed by unpacking the source code into the build directory of the current build. This also ensures that we don't infer with a otherwise assumed static registry cache directory.
lnicola
approved these changes
Apr 4, 2024
urschrei
pushed a commit
to kylebarron/proj
that referenced
this pull request
Jul 1, 2024
Unpacking the proj source code to the cargo registry cache can run into potential data races for concurrent builds. This can be fixed by unpacking the source code into the build directory of the current build. This also ensures that we don't infer with a otherwise assumed static registry cache directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpacking the proj source code to the cargo registry cache can run into potential data races for concurrent builds. This can be fixed by unpacking the source code into the build directory of the current build. This also ensures that we don't infer with a otherwise assumed static registry cache directory.