Made axios work

[Adesin-fr]

The error seems to come from the Connector not having a constructor, and maybe some other fixes I've done, don't remember fully... ;)

[leob]

The error seems to come from the Connector not having a constructor, and maybe some other fixes I've done, don't remember fully... ;)

@Adesin-fr Okay thanks, odd that the Connection thing would fix it because it was also complaining about other things not related to Connection, but okay, you made some other changes as well (e.g. the Typescript config) ...

But yes, ESLint seems to run successfully now in Github.

I'm going to merge this but then I'm not going to publish a new version right away - I'll first test it with our app as a "local dependency", and try to get the reconnect stuff working in our app.

I see that you pinned the echo dependency to a specific version, I think I'll want to set it to a higher version (the one we use in our app).

I'd also love to get rid of yarn and switch to npm at some point, but we should probably do that in a separate PR (not change too many things at the same time), but if it gives me too many headaches then i might dump yarn right away.

Once all of this works I'll publish a new version!

[leob]

The error seems to come from the Connector not having a constructor, and maybe some other fixes I've done, don't remember fully... ;)

@Adesin-fr When I pull down the code and I do an npm install or an npm run build, I'm still getting these warnings:

(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
axios (imported by js-src/Websocket.ts)
(!) Missing global variable name
Use output.globals to specify browser global variable names corresponding to external modules
axios (guessing 'axios')
created ./dist/laravel-echo-api-gateway.js, ./dist/laravel-echo-api-gateway.common.js, ./dist/laravel-echo-api-gateway.iife.js in 1.1s

But in the end it did create the output JS files - so yeah, maybe it's okay - I'm going to check if the build works in Github ...

[Adesin-fr]

Yeah I saw this.
Don't know why, but it seems axios version is pretty old, and ditching it for pure fetch calls would surely remove those errors !

[leob]

Yeah I saw this. Don't know why, but it seems axios version is pretty old, and ditching it for pure fetch calls would surely remove those errors !

@Adesin-fr We tried that already but that wasn't a big success, we reverted that ... no we're keeping Axios, I'm trying to get the import working now.

P.S. I'm closing this PR because I made a follow-up PR (#37) ... I'm also trying to replace yarn by npm, I find it pretty annoying to "mix" the two all the time, I just want npm only.

[leob]

I'm closing this PR because I made a follow-up PR (#37) ... I'm also trying to replace yarn by npm, I find it pretty annoying to "mix" the two all the time, I just want npm only.

[leob]

I'm closing this PR because I made a follow-up PR (#37) ... I'm also trying to replace yarn by npm, I find it pretty annoying to "mix" the two all the time, I just want npm only.

@Adesin-fr I took your PR, then used that to create a new PR, messed around with it, got rid of yarn and replaced it by npm, messed around a bit more, and now finally the build and the npm-publish seems successful - yay !

I'm now going to test it with our app, let's keep our fingers crossed ... :)