Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host resolution for docker compose internal network. #20

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mki-c2c
Copy link
Contributor

@mki-c2c mki-c2c commented Jan 28, 2025

This allows the maelstro docker component to reach for the gateway

This allows the maelstro docker component to reach for the gatewway
@mki-c2c mki-c2c requested a review from jeanmi151 January 28, 2025 14:17
Copy link
Contributor

@jeanmi151 jeanmi151 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunatly this might not work/be as easy in kubernetes stuff

it is possible like made in here : georchestra/helm-georchestra#109
not against but @edevosc2c might say something

@edevosc2c
Copy link
Member

Maybe I know the context here? Is this related to https://camptocamp.atlassian.net/browse/GSREN-263?

@mki-c2c
Copy link
Contributor Author

mki-c2c commented Jan 28, 2025

well, there is the alternative to directly talk to the security proxy without need for resolving caddy.
we can put this ticket on hold

@edevosc2c
Copy link
Member

edevosc2c commented Jan 28, 2025

If you need to communicate with gateway in a docker context, why don't you have a setting to specific the internal hostname of gateway or proxy?

something like:

internal_gateway_hostname: gateway

Why the need to pass through the web server (caddy)? Can't you send the requests internally?

You can reach out to other services through their service name: https://github.com/georchestra/maelstro/blob/main/georchestra/geor-compose.yml#L79

@jeanmi151 jeanmi151 merged commit 1532bb1 into main Jan 30, 2025
3 checks passed
@jeanmi151 jeanmi151 deleted the GSREN-263_docker_internal_dns branch January 30, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants