Catch EDR AttributeError
errors more fine grained
#2118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
try
except
over everyAttributeError
in thequery
functionAttributeError
it will mistakenly say that the query is not implemented and it is possible to get confusing errors like these, when it reality is was coming from anAttributeError
in the providerFix
This PR fixes this behavior to:
getattr
call so otherAttributeErrors
are preservedquery_type
is passed in. Otherwise you would try to dogetattr
withNone
which could in the future cause other confusing issuesRelated Issue / discussion
N/A
Additional information
N/A
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)