Skip to content

ENH: match geopandas sjoin and clip API #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 31, 2022
Merged

ENH: match geopandas sjoin and clip API #149

merged 7 commits into from
Jan 31, 2022

Conversation

martinfleis
Copy link
Member

Closes #127, xref #130

  • add clip as a GeoDataFrame method
  • support GeoSeries in clip and add it the method
  • add sjoin as a GeoDataFrame method
  • change op to predicate in sjoin

@martinfleis martinfleis added this to the 0.1 milestone Jan 30, 2022
jorisvandenbossche
jorisvandenbossche reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit 743e6ee into geopandas:main Jan 31, 2022
@martinfleis martinfleis deleted the methods branch January 31, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging this pull request may close these issues.

clip calls wrong clip function
2 participants
@martinfleis @jorisvandenbossche