Skip to content

Conversation

@yingyil06
Copy link
Contributor

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yingying,
A nice first pull request, typo fixes (and other improvements) are always welcome. Welcome to the ASPECT contributors!

@gassmoeller
Copy link
Member

The documentation tester seems to have issues at the moment (probably cloud connection issues), but it seems unrelated to your change. We will restart the tester later and it should succeed then.

"edges of geographical quadrangle (in degrees)"
"Chunk (inner || outer) radius: Radii at bottom and top of chunk"
"edges of geographical quadrangle (in degrees) "
"Chunk (inner || outer) radius: Radii at bottom and top of chunk "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an alternative would be to add newlines (\n) to separate these 3 items.

@gassmoeller
Copy link
Member

Ah, I see now why the documentation tester keeps failing. You based this branch on top of a very old main branch of ASPECT (from 2023), therefore the configuration file for the documentation build is out of date. Can you ask @anne-glerum or @Minerallo for help rebasing this pull request onto a recent version of ASPECT? If they are not available I can guide you through it in comments, but it is easier if someone can look over your shoulder while you do it.

@anne-glerum
Copy link
Contributor

@gassmoeller We'll have a look next week to rebase!

@yingyil06
Copy link
Contributor Author

@gassmoeller Hi Rene, thanks for pointing that out. I indeed based this branch on a very old main branch of ASPECT. I will have a look with Anne.

@yingyil06
Copy link
Contributor Author

@gassmoeller With the help of Anne, I've rebased the branch on main.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MFraters MFraters merged commit f4afadd into geodynamics:main Nov 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants