-
Notifications
You must be signed in to change notification settings - Fork 258
Fixed a typo #6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a typo #6737
Conversation
gassmoeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yingying,
A nice first pull request, typo fixes (and other improvements) are always welcome. Welcome to the ASPECT contributors!
|
The documentation tester seems to have issues at the moment (probably cloud connection issues), but it seems unrelated to your change. We will restart the tester later and it should succeed then. |
| "edges of geographical quadrangle (in degrees)" | ||
| "Chunk (inner || outer) radius: Radii at bottom and top of chunk" | ||
| "edges of geographical quadrangle (in degrees) " | ||
| "Chunk (inner || outer) radius: Radii at bottom and top of chunk " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an alternative would be to add newlines (\n) to separate these 3 items.
|
Ah, I see now why the documentation tester keeps failing. You based this branch on top of a very old main branch of ASPECT (from 2023), therefore the configuration file for the documentation build is out of date. Can you ask @anne-glerum or @Minerallo for help rebasing this pull request onto a recent version of ASPECT? If they are not available I can guide you through it in comments, but it is easier if someone can look over your shoulder while you do it. |
|
@gassmoeller We'll have a look next week to rebase! |
|
@gassmoeller Hi Rene, thanks for pointing that out. I indeed based this branch on a very old main branch of ASPECT. I will have a look with Anne. |
|
@gassmoeller With the help of Anne, I've rebased the branch on main. |
gassmoeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
Describe what you did in this PR and why you did it.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: