-
Notifications
You must be signed in to change notification settings - Fork 258
[WIP] [Request of initial comments] Add direction dilation. #6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think allowing an anisotropic dilation makes sense, but we need to coordinate the change with #6373, which contains important fixes to the dilation as well. |
|
I will write another comment later after we had a discussion about #6373. |
|
Quick summary: We will proceed with #6373 as quickly as possible as that is a fix that improves the accuracy and solver performance of the dilation. Afterwards we can continue with this PR. |
|
Thanks for the comments and coordinating this @gassmoeller! Sounds good to me. I will update the pull request to use a tensor instead and keep an eye on #6373 in the meantime. |
08e245e to
ed987d7
Compare
d610729 to
9b868da
Compare
For a diking algorithm, I would like to be able to only add dilation in a certain direction. I personally think it is best to be general with this and let the material model decide exactly how much dilation needs to go in each direction.
I originally thought that I should just add a new direction dilation additional output, but after trying that out I think just making the dilation a dim vector might be cleaner. So that is what is implemented here.
I am happy to get comments on this approach now and be convinced that a different approach might be better.