app-text/simplenote-desktop-bin: new package, add 2.23.0

[APN-Pucky]

Slightly adapted and renamed ebuild from https://github.com/BlueManCZ/edgets/blob/master/app-text/simplenote/simplenote-2.22.1.ebuild in agreement with original author BlueManCZ/edgets#18 (comment).

[stkw0]

To add the package to the tree, please follow https://wiki.gentoo.org/wiki/Project:GURU/Information_for_Contributors to request commit access to the dev branch. Pull requests for new packages are not (or only exceptionally) merged.

[APN-Pucky]

Thanks, I'll do that.

[Nowa-Ammerlaan]

Take a look at the ebuilds for discord, rocketchat-desktop-bin, whatsapp-desktop-bin and jupyterlab-desktop-bin. You can improve this a lot by using the chromium-2 eclass (mainly for handeling translations). Inside the electron app there is a list of all bundled dependencies and the corresponding licenses, you can use this to populate LICENSE. Note also the specific handeling of the chrome-sandbox binary in those ebuilds. I also recommend using an rpm instead of a deb if possible, you won't need unpacker.eclass then.

I recommend using any of the above mentioned ebuilds as a template instead. Packaging an electron app looks simple at first glance, but it is actually pretty complicated to get right, luckily we already have a bunch of electron apps packaged.

One day we should maybe make an electron-app.eclass.

[Nowa-Ammerlaan]

Suggested change

	EAPI=8
	inherit unpacker xdg
	EAPI=8
	inherit unpacker xdg

[Nowa-Ammerlaan]

Suggested change

	S=${WORKDIR}
	LICENSE="GPL-2"
	SLOT="0"
	KEYWORDS="-* ~amd64 ~arm64"
	IUSE="doc"
	RESTRICT="bindist mirror"
	S="${WORKDIR}"
	LICENSE="GPL-2"
	SLOT="0"
	KEYWORDS="-* ~amd64 ~arm64"
	IUSE="doc"
	RESTRICT="bindist mirror"

WORKDIR needs quoting, LICENSE list is probably incomplete since it is an electron app.

[Nowa-Ammerlaan]

Suggested change

	unpack "usr/share/doc/simplenote/changelog.gz" || die "unpack failed"
	rm -f "usr/share/doc/simplenote/changelog.gz" || die "rm failed"
	mv "changelog" "usr/share/doc/simplenote" || die "mv failed"
	unpack "usr/share/doc/simplenote/changelog.gz"
	rm "usr/share/doc/simplenote/changelog.gz" || die
	mv "changelog" "usr/share/doc/simplenote" || die

unpack is a built-in function, and thus already calls die.

[Nowa-Ammerlaan]

Suggested change

	if use doc ; then
	dodoc -r "usr/share/doc/simplenote/"* || die "dodoc failed"
	fi
	dosym ../../opt/Simplenote/simplenote "/usr/bin/simplenote" || die "dosym failed"
	if use doc ; then
	dodoc -r "usr/share/doc/simplenote/"*
	fi
	dosym ../../opt/Simplenote/simplenote "/usr/bin/simplenote"

same here, these are also built-ins.

[Nowa-Ammerlaan]

Suggested change

	if use doc ; then
	dodoc -r "usr/share/doc/simplenote/"* || die "dodoc failed"
	fi
	dosym ../../opt/Simplenote/simplenote "/usr/bin/simplenote" || die "dosym failed"
	if use doc ; then
	dodoc -r "usr/share/doc/simplenote/"*
	fi
	dosym ../../opt/Simplenote/simplenote "/usr/bin/simplenote"

same here, these are also built-ins.

[Nowa-Ammerlaan]

This is an electron app, so I am pretty sure there are more dependencies.

[APN-Pucky]

Take a look at the ebuilds for discord, rocketchat-desktop-bin, whatsapp-desktop-bin and jupyterlab-desktop-bin. You can improve this a lot by using the chromium-2 eclass (mainly for handeling translations). Inside the electron app there is a list of all bundled dependencies and the corresponding licenses, you can use this to populate LICENSE. Note also the specific handeling of the chrome-sandbox binary in those ebuilds. I also recommend using an rpm instead of a deb if possible, you won't need unpacker.eclass then.

I recommend using any of the above mentioned ebuilds as a template instead. Packaging an electron app looks simple at first glance, but it is actually pretty complicated to get right, luckily we already have a bunch of electron apps packaged.

One day we should maybe make an electron-app.eclass.

rpm does not exist for arm64, so I decided to stick with deb for now (if I see it right rpm needs a rpm.eclass).
I used the "ancient shell one-liner" to find the RDEPENDS, but had to filtered other electron apps out that also showed up there.

[APN-Pucky]

Thanks @Nowa-Ammerlaan, given https://bugs.gentoo.org/949072 I assume I should be able to merge it into dev myself now.

[Nowa-Ammerlaan]

Thanks @Nowa-Ammerlaan, given https://bugs.gentoo.org/949072 I assume I should be able to merge it into dev myself now.

Yes! There are some instructions on the wiki if it doesn't work right away.