Skip to content

add iansan#2374

Draft
imring wants to merge 2 commits intogenshinsim:mainfrom
imring:iansan
Draft

add iansan#2374
imring wants to merge 2 commits intogenshinsim:mainfrom
imring:iansan

Conversation

@imring
Copy link
Collaborator

@imring imring commented Mar 28, 2025

  • New character package
  • Config in character package
  • Run pipeline with added config (generates character curve, talent stats, .generated.json files)
  • Character key
  • Shortcuts for character key
  • Update mode_gcsim.js with shortcuts for syntax highlighting
  • Add Character package to imports
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • PoiseDMG (blunt attacks only for now)
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Xingqiu/Yelan N0 (optional)
  • Xianyun Plunge (optional)

@imring imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Mar 28, 2025
@ErrorRaffyline0
Copy link

I think I speak for everyone when I say it is expected that any maintainer working on this PR would give up early on, when being hit with the realization that 90% of Iansan's kit relies upon implementing movement values for hundreds of character animations. But thanks for trying at least. ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants