Skip to content

Expanded booking#2367

Open
jwalk-511 wants to merge 7 commits intogenshinsim:mainfrom
jwalk-511:geo-crystallize-booking
Open

Expanded booking#2367
jwalk-511 wants to merge 7 commits intogenshinsim:mainfrom
jwalk-511:geo-crystallize-booking

Conversation

@jwalk-511
Copy link
Contributor

@jwalk-511 jwalk-511 commented Mar 21, 2025

Crystallize added.
Warnings for booking events (swap cd manipulation or crystallize gcd manipulation) collected into a single "failure" type.

Display of warnings not yet working.
Documentation of new system functions not yet added.

Of all the changed lines, the vast majority are attributed to auto-generated result.ts

All non-english locales were translated by google translate

Booking emits a new event type, OnTimeManip
Time manipulation functions write to sample, under cooldown type logs.

Usage of any booking function causes a "Time Manipulation" Warning to show on the results page. This also displays total time manipulation per character, though that's secondary to warning appearing at all.

Crystallize added.
Warnings for booking events (swap cd manipulation or crystallize gcd manipulation) collected into a single "failure" type.

Display of warnings not yet working.
Documentation of new system functions not yet added.
@jwalk-511 jwalk-511 marked this pull request as draft March 21, 2025 00:23
Notes for anyone else who needs to run autogen

install protoc-gen-go-grpc
Run the protoc cmd found in
@jwalk-511
Copy link
Contributor Author

jwalk-511 commented Mar 21, 2025

Note: Because I don't have all the files needed for pipeline, I ran portions of Taskfile.yml manually.

Protoc:
Software versions:
protoc-gen-go: v1.36.4
protoc-gen-go-grpc 1.5.1
protoc: libprotoc 29.3

Commands used

        protoc --experimental_allow_proto3_optional \
               --go_out=module=github.com/genshinsim/gcsim:. \
              --go-grpc_out=module=github.com/genshinsim/gcsim:. \
              --plugin=./ui/node_modules/.bin/protoc-gen-ts_proto \
              --ts_proto_opt=useOptionals=all \
              --ts_proto_opt=snakeToCamel=json \
              --ts_proto_out=./ui/packages/types/src/generated \
              --ts_proto_opt=esModuleInterop=true \
              --ts_proto_opt=useJsonName=true \
              --ts_proto_opt=outputIndex=true \
              protos/**/*.proto
      - go run scripts/bsontags/main.go -dir ./pkg/model -verbose
      - go run scripts/bsontags/main.go -dir ./backend/pkg/services/db -verbose
      - go run scripts/bsontags/main.go -dir ./backend/pkg/services/share -verbose

MSGP
msgp: http://archive.ubuntu.com/ubuntu noble/universe amd64 msgp amd64 1.1.9-1

  msgp:
    dir: ./pkg/stats
    cmds:
      - go generate

Embed
The embed script wouldn't work for me, so instead I ran the contents of the shell directly

cd ui
yarn
yarn build:embed
mv ./packages/embed/dist ../backend/cmd/preview/dist

Since swap_delay must always be at least 1, reduce minimum swap_cd/swap_icd from 1 down to 0. Also fix hitlag param, which had inverted logic.
@jwalk-511 jwalk-511 marked this pull request as ready for review March 21, 2025 21:07
@imring imring added kind: enhancement New feature or request area: pkg Related to core logic labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: pkg Related to core logic kind: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants