Add Ororon high jump and high_plunge. by jwalk-511 · Pull Request #2334 · genshinsim/gcsim

jwalk-511 · 2025-02-10T04:58:31Z

TODO: Pipeline Run

When Ororon uses a hold jump in-game, he initiates a form of NS transmission, leaping high in the air and gaining the NS Blessing status. This NS Blessing exists independently of the NS Blessing from his A1 passive but can still allow the extended Scroll of the Hero of the Cinder City 4pc effect to trigger.

While airborne, he can fall, high plunge, or aim. Aim is not implemented here. Ororon cannot cancel his high jump before reaching max height, so low_plunge is also not implemented. To prevent implementation of movement tech, Ororon is forcefully transitioned into the fall state on the frame he would open his glider.

When Ororon uses high jump, he drains 75 stamina. Stamina does not resume regeneration until he initiates another action. He does not require all 75 stamina to initiate a high jump and will drain to 0 if less than 75 stamina remains. When Ororon has drained all stamina, ~~he is unable to initiate a normal fall cancel and will only be able to plunge~~ Ororon can't cancel normally but can initiate an equivalent fall cancel by attempting to walk (glide) forward.

Implementation details:
Ororon's high jump code schedules a callback to a Player.exec() call as a proof of concept of forcefully changing the player's animation state. The concepts used should be applicable to any character who automatically executes an action outside of a GCSL statement, such as Mavuika Charge starting in the NA state and transitioning to the CA state, or Chasca transitioning from the charge state to a falling state upon NS expiry. This is not strictly needed for Ororon, and can be changed upon request.

GCSL notes:
jump:
param hold:

0 (default): Initiates a normal jump, calls already-implemented code.
< 0: Sets hold to MaxHold. Fall through to below case.
> 0: Subtract 1. Hold=1 implies minimum length hover before fall cancel. Fall will be initiated MinFallCancelFrames + Hold frames after the jump begins.

High_Plunge:
param fall:

0 (default) Perform a normal high-plunge.
1: Simulate a pressing the jump button after reaching max jump height, initiating free-fall. A plunge cannot be used after a fall has been initiated.
Frames done:
https://docs.google.com/spreadsheets/d/1TUoz-kPRTnH2ShCxijokC46CBMjtYj5qRztgsd_QZR0/edit?pli=1&gid=1526454145#gid=1526454145
High Jump->plunge/fall frames
All jump[hold!=0]->X frames, other than plunge/fall (this isn't needed, only plunge and fall can occur after high jump)
High_plunge->Swap frames
All high_plunge->X frames counting other than swap (recording done).
high_plunge[fall=1]->Swap frames
All high_plunge[fall=1]->X frames counting, other than swap (recording done).
NS Transmission start and end relative to action frames.
Stam drain
Stam allowable resume frames. https://discord.com/channels/845087716541595668/983391844631212112/1338586013752229889

Other todo:

Min required stamina to initiate high jump (Drains 75, but able to initiate with less than 75)
High Plunge[fall=0].
Stamina drain adjustment when stamina mods are in effect (e.g. anemo resonance)
Update mode_gcsim.js with shortcuts for syntax highlighting (Does this need to be done for new Params?)
Update documentation

Code implemented:

JUMP

add hold parameter to JUMP action
Require <75 stam before using high jump. Only requires 1 ~~? 5? TBD~~
Automatically transition from JUMP[hold != 0] to FALL action when NS transmission expires, if user does not manually exit (through plunge or plunge[fall=1]) first)
Grant AirborneOroron

STAMINA

Remove 75 stamina.
Prevent stamina regen.
WONTDO: Stam check should actually happen a little after jump is initiated.

NS BLESSING

Give NS Transmission blessing status while airborne
Overload get_status method to identify ororon as having Nightsoul Blessing state when either he has Nightsoul Blessing status OR when he has NS Transmission status
Remove NS Transmission status when NS transmission ends

High PLUNGE

Implement AirborneOroron plunge.
Implement AirborneOroron plunge[fall!=0] param
Require AirborneOroron status to use plunge

STAMINA

Allow stamina to regen again after plunge
Allow stamina to regen again after plunge[fall=1]

NS BLESSING

Remove NS Transmission on plunge // Assume it happens immediately
Remove NS Transmission on fall // Assume it happens immediately

Notes: Stamina is probably terribly bugged and also overcomplicated. My ability to accurately test stamina drain and resume timings is hampered by https://library.keqingmains.com/evidence/combat-mechanics/damage/other/client-and-server#high-ping-interactions.
Stamina regen timing assumed to occur at plunge start frame if fall=0, or on hitting ground if fall=1. https://discord.com/channels/845087716541595668/983391844631212112/1338586013752229889

Implement Hold Param for Jump. Add NS Blessing on Held Jump. Add Airborne Ororon State. Add High_Plunge and High_Plunge[fall=1], allowable while ororon has AirborneOroron. Todo: Frames

Most packages don't use Characters, they use charWrappers. I can't overload charWrapper, so just require check for 2 statuses instead.

Ororon test config validates frames and animation state changes work as expected.

Ororon can high_plunge before he can use fall cancel, so added lines to allow delay of fall cancel if triggered too early.

…smission blessing is added

Updated fall->jump cancels, plunge->jump cancel, plunge hitmarks, and manually added plunge talent curves.

internal/characters/ororon/testconfig.txt

internal/artifacts/obsidiancodex/obsidiancodex.go

internal/characters/ororon/jump.go

Remove test config. Modify enter/exit of transmission status to be handled by method calls within nightsoul.go. Refactored Ororon to use above method calls instead of modifying status directly.

…ding NS duration on refresh Removed independent NS transmission. - Ororon does not exit blessing on A1 exit if jump blessing is active. - Ororon does not exit blessing on Jump exit if A1 blessing is active - Remove all references to nightsoul.NightsoulTransmissionBlessingKey Fix A1 NS duration refresh. - Call A1EnterBlessing every time. - Add check to A1ExitBlessing to return early if A1EnterBlessing has been called again since last call. Fix lint - Remove constant return NIL from private method.

imring · 2025-03-08T11:24:50Z

internal/characters/ororon/plunge.go

+	// Plunge -> X
+	plungeFrames = frames.InitAbilSlice(66) // Default is From plunge animation start to swap icon un-gray
+	plungeFrames[action.ActionAttack] = 68
+	plungeFrames[action.ActionAim] = 66
+	plungeFrames[action.ActionSkill] = 65
+	plungeFrames[action.ActionBurst] = 65
+	plungeFrames[action.ActionDash] = 53
+	plungeFrames[action.ActionJump] = 82
+	plungeFrames[action.ActionWalk] = 80
+	plungeFrames[action.ActionSwap] = 66


Source shared in ororon.go review comment

imring · 2025-03-08T11:24:59Z

internal/characters/ororon/jump.go

+	c.QueueCharTask(func() {
+		h := c.Core.Player
+		// Apply stamina reduction mods.
+		stamDrain := h.AbilStamCost(c.Index, action.ActionJump, map[string]int{"hold": 1})


but there's the map from the Jump method

That's true; I was trying to make the function just a little bit more lightweight by only passing the hold integer as a parameter, rather than the entire p map. But the fact that I have to re-construct the map and pass it to h.AbilStamCost probably cancels that out anyway

imring · 2025-03-08T11:26:42Z

internal/characters/ororon/ororon.go

+	// Hold Jump
+	jumpHoldFrames = make([][]int, 2)
+	// Hold Jump -> X
+	jumpHoldFrames[0] = frames.InitAbilSlice(60 * 10) // set to very high number for most abilities
+	jumpHoldFrames[0][action.ActionHighPlunge] = plungeCancelFrames
+	// Fall -> X
+	jumpHoldFrames[1] = frames.InitAbilSlice(fallFrames)
+	jumpHoldFrames[1][action.ActionAttack] = 45
+	jumpHoldFrames[1][action.ActionAim] = 46
+	jumpHoldFrames[1][action.ActionSkill] = 45
+	jumpHoldFrames[1][action.ActionBurst] = 46
+	jumpHoldFrames[1][action.ActionDash] = 46
+	jumpHoldFrames[1][action.ActionJump] = 45
+	jumpHoldFrames[1][action.ActionWalk] = 47
+	jumpHoldFrames[1][action.ActionSwap] = 44


move jump frames to jump.go

frames source?

Frames source for fall->x and for low_plunge->x: https://docs.google.com/spreadsheets/d/1ru_C_1vh_0k3u-NdJFcq079N_vstn055PVsL66eCoN8/edit?gid=2018562987#gid=2018562987

jumpHoldFrames[1] corresponds to fall frames, which is used by both low_plunge[fall=1] and by high_jump, when the jump is allowed to expire naturally. I left it in ororon.go to make it more obvious it wasn't only for jump.go

I'll move frames to jump.go anyway

I don't think anyone's verified the frames I counted yet.
Once they are verified, I think they should be added to the main oro frames sheet, and then I can link that within the comments in the code

jwalk-511 added 9 commits February 8, 2025 16:09

Add highjump

1e24eed

Initial commit

e444c5f

Implement Hold Param for Jump. Add NS Blessing on Held Jump. Add Airborne Ororon State. Add High_Plunge and High_Plunge[fall=1], allowable while ororon has AirborneOroron. Todo: Frames

Clamp minimum stamina at 0

795418b

Fix external detection of Nightsoul Transmission status

7d44323

Most packages don't use Characters, they use charWrappers. I can't overload charWrapper, so just require check for 2 statuses instead.

Remove fall delay on 0 stamina, can fall early with glide

9f145c9

Added test config, added fake plunge frames.

87e8699

Ororon test config validates frames and animation state changes work as expected.

fix lint

0c3ec76

Update stamina drain/resume regen timings, implement some frames.

3298819

Ororon can high_plunge before he can use fall cancel, so added lines to allow delay of fall cancel if triggered too early.

Fix lint again

a12a430

jwalk-511 marked this pull request as draft February 11, 2025 03:38

jwalk-511 added 4 commits February 10, 2025 22:07

Accommodate possibility that High Jump may be canceled before NS Tran…

4523af3

…smission blessing is added

Add frames for plunge->X and fall->X

223b439

Added dmg for plunge. Pipeline not yet run.

d02735e

Update final frame counts

0bf4775

Updated fall->jump cancels, plunge->jump cancel, plunge hitmarks, and manually added plunge talent curves.

jwalk-511 marked this pull request as ready for review February 13, 2025 18:18

imring reviewed Feb 16, 2025

View reviewed changes

internal/characters/ororon/testconfig.txt Outdated Show resolved Hide resolved

internal/artifacts/obsidiancodex/obsidiancodex.go Outdated Show resolved Hide resolved

internal/characters/ororon/jump.go Outdated Show resolved Hide resolved

imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Feb 16, 2025

jwalk-511 added 2 commits February 16, 2025 12:15

Fix review comments 2 and 3

c4c0078

Remove test config. Modify enter/exit of transmission status to be handled by method calls within nightsoul.go. Refactored Ororon to use above method calls instead of modifying status directly.

imring reviewed Mar 8, 2025

View reviewed changes

review compliance

a6544c6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Ororon high jump and high_plunge.#2334

Add Ororon high jump and high_plunge.#2334
jwalk-511 wants to merge 16 commits intogenshinsim:mainfrom
jwalk-511:ororon-highjump

jwalk-511 commented Feb 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imring Mar 8, 2025

Uh oh!

jwalk-511 Mar 8, 2025

Uh oh!

imring Mar 8, 2025

Uh oh!

jwalk-511 Mar 8, 2025

Uh oh!

imring Mar 8, 2025

Uh oh!

imring Mar 8, 2025

Uh oh!

jwalk-511 Mar 8, 2025

Uh oh!

jwalk-511 Mar 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jwalk-511 commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code implemented:

JUMP

STAMINA

NS BLESSING

High PLUNGE

STAMINA

NS BLESSING

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jwalk-511 commented Feb 10, 2025 •

edited

Loading