Add separated substats from import#2308
Draft
just1ce5 wants to merge 1 commit intogenshinsim:mainfrom
Draft
Conversation
imring
added
kind: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: add feature so that artifact substats that are imported from Enka are written to the config as separate lines.
The Demand: I think this feature is extremely needed for those who use gcsim to analyze their builds (speaking from my experience doing team reviews on-stream using gcsim). Otherwise, if you want to slightly change the build, you'll always need to use calculator to add and subtract main/sub stats, which is frustrating. Initially, I thought to implement the UI feature, where you can adjust artifact main and sub stats using UI, but, hey, it will take forever and we need to start with something.
Concerns: I am not familiar with TypeScript. I'm neither looked at the whole front-end code nor Idk how to debug it, so what I'm providing is just a sketch (which I'm not sure if working). I need someone to help me check whether it works and how to fix it/rework it to the acceptable condition. Also, I'm not sure if this concrete change will affect GO import. So, I'm marking this PR as a draft.