Skip to content
This repository was archived by the owner on Aug 18, 2022. It is now read-only.

Move footer to bottom#44

Open
TheEZIC wants to merge 1 commit intogenshinsim:mainfrom
TheEZIC:bottom-footer
Open

Move footer to bottom#44
TheEZIC wants to merge 1 commit intogenshinsim:mainfrom
TheEZIC:bottom-footer

Conversation

@TheEZIC
Copy link
Contributor

@TheEZIC TheEZIC commented Mar 20, 2022

No description provided.

@srliao
Copy link
Contributor

srliao commented Mar 22, 2022

image
@TheEZIC I think this is why I had it like what it was before.

What's this change required for?

@TheEZIC
Copy link
Contributor Author

TheEZIC commented Mar 22, 2022

As I said before, If you open "Simulator" tab then on loading stage you have footer on middle of screen.

@TheEZIC
Copy link
Contributor Author

TheEZIC commented Mar 22, 2022

image

@srliao
Copy link
Contributor

srliao commented Mar 22, 2022

Oh ok. That I can fix but maybe not touch the body.

@TheEZIC
Copy link
Contributor Author

TheEZIC commented Mar 22, 2022

You can get same result by css calc function. Set min-height: calc(100vh - (#{$header-height} + #{$footer-height})) (it's scss code example) to your content block. But this method requires footer and header fixed height. Therefore, it loses its versatility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants