feat: base action on call command#200
Merged
Merged
Conversation
* test: setup jest configuration with typescript * refactor: removed path alias and changed simulator service toa class injected in the command declaration * test: added init action adn command tests * docs: added testing section on readme file * fix: handle Fetch Error (Mac M3) * refactor: improved function response * fix: await for runSimulator async function * fix: added init action test * fix: solving conflicts * test: added reset docker images and containers calls from init
…erwritten (#38) * feat: added initial warning about reseting the setup * test: added a test for new step introduced
* feat: added initial warning about reseting the setup * test: added a test for new step introduced * feat: added optional branch when fetching the simulator from github * feat: added branch name on init and up commands * test: added tests for branch option on init command
* chore: added npm command for beta release * ci: added github action for beta release
* fix: removed non existing simulator endpoint * refactor: adapted ping simulator response for current and next version * tests: removed non existing simulator endpoint test
* fix: removed non existing simulator endpoint * refactor: adapted ping simulator response for current and next version * tests: removed non existing simulator endpoint test
* add node and docker version checks * remove redundant check * set correct version numbers, add todo * use config constant for versions * refactor methods and improve error handling * implement PR comments: split install and version checks in two separate checks, move checkVersion method to simulator service * add tests for version checks on init command * flip version issue evalution * separate checks in two steps * remove console log --------- Co-authored-by: Den <den@Deniss-MacBook-Pro.local>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 27 27
Lines 1361 1462 +101
Branches 330 363 +33
==========================================
+ Hits 1361 1462 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
epsjunior
changed the title
cristiam86
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#197
Brief Overview
genlayer callcommand to extend Base Action.Is important to approve this PR before: #194