Skip to content

Format BigDecimal values must round HALF_UP #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iroqueta merged 2 commits into from
May 13, 2025
Merged

Format BigDecimal values must round HALF_UP #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c491cf
Format BigDecimal values must round HALF_UP
iroqueta Apr 14, 2025
54188ec
Merge branch 'master' into BigdecimalRoundHALF_UP
iroqueta May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/src/main/java/com/genexus/LocalUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.genexus;

import java.math.RoundingMode;
import java.util.*;
import java.text.*;

Expand Down Expand Up @@ -1713,6 +1714,7 @@ private String formatBigDecimal(java.math.BigDecimal value, String picture, Numb
{
DecimalFormat df = (DecimalFormat) numberFormat;
df.applyPattern(pictureToNumberFormat(withoutSuffixPicture));
df.setRoundingMode(RoundingMode.HALF_UP);
if ( CommonUtil.in(picture, '.') || CommonUtil.in(picture, ','))
{
formatted = alignAndPad(df.format(value), '0', withoutSuffixPicture, floating, numberFormat, originalPicture);
Expand Down
7 changes: 7 additions & 0 deletions java/src/test/java/com/genexus/TestCommonUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,13 @@ public void testFormat() {
result = ui.getLocalUtil().format(bigDecimalValue, picture);
Assert.assertEquals(expectedResult, result);

bigDecimalValue = new BigDecimal(2.5);
picture = "Z,ZZZ,ZZZ,ZZZ,ZZZ,ZZ9";
expectedResult = " 3";

result = ui.getLocalUtil().format(bigDecimalValue, picture);
Assert.assertEquals(expectedResult, result);

bigDecimalValue = new BigDecimal(-12.5);
picture = "$Z9.9";
expectedResult = "-$12.5";
Expand Down
Loading