Remove manual TransactionExtended Hashable/Equatable

[DRadmir]

No longer needed - protocols are now auto-generated from core typeshare.

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the handling of Equatable and Hashable protocol conformance for transaction-related data structures. By leveraging auto-generation from the core typeshare, redundant manual implementations have been removed, leading to cleaner and more maintainable code. The change ensures that these essential protocols are correctly applied to key data types, aligning with the new auto-generation process.

Highlights

• Protocol Conformance Removal: Removed the manual implementation of Equatable and Hashable protocols for TransactionExtended as they are now auto-generated.
• Hashable Conformance Addition: Added Hashable conformance directly to Transaction, TransactionExtended, and TransactionUtxoInput structs.
• Core Subproject Update: Updated the core subproject to a newer commit, likely to reflect the changes enabling auto-generation of protocols.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Packages/Primitives/Sources/Extensions/TransactionExtended+Primitives.swift
  • Removed manual Equatable and Hashable extensions for TransactionExtended.
• Packages/Primitives/Sources/Transaction.swift
  • Conformed Transaction struct to Hashable protocol.
• Packages/Primitives/Sources/TransactionExtended.swift
  • Conformed TransactionExtended struct to Equatable and Hashable protocols.
• Packages/Primitives/Sources/TransactionUtxo.swift
  • Conformed TransactionUtxoInput struct to Hashable protocol.
• core
  • Updated the core subproject commit hash.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the manual, incomplete implementations of Equatable and Hashable for TransactionExtended. The previous Equatable implementation was incorrect as it only compared the transaction property, ignoring other properties of the struct. By adding Hashable conformance to Transaction, TransactionExtended, and TransactionUtxoInput, and Equatable to TransactionExtended, this PR allows the compiler to synthesize the correct implementations. This change ensures that equality and hashing operations consider all properties of these value types, fixing potential bugs when using them in collections like Set or as dictionary keys. The changes are a significant improvement to code correctness and maintainability.