Skip to content

[ENH] Add name_id_map parameter to add_orientations and enable serialization validation #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

[ENH] Add name_id_map parameter to add_orientations and enable serialization validation #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca8bab
[ENH] Add `name_id_map` support in orientation data manipulation
Leguark Sep 18, 2025
fd5675f
[CLN] Simplify Hecho example by removing serialization logic and enha…
Leguark Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions examples/examples/real/Hecho.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

# Aux imports
import pandas as pn
from gempy.modules.serialization.save_load import _validate_serialization

# Importing gempy
import gempy as gp
Expand Down Expand Up @@ -126,7 +127,7 @@
gp.set_section_grid(
grid=geo_model.grid,
section_dict={
'section': ([0, 0], [16, 0], [321, 91])
'section': ((0., 0.), (16., 0.), (321, 91))
},
)

Expand All @@ -149,7 +150,8 @@
y=new_orientations.data['Y'],
z=new_orientations.data['Z'],
pole_vector=new_orientations.grads,
elements_names=fn
elements_names=fn,
name_id_map=element.surface_points.name_id_map
)

# %%
Expand Down Expand Up @@ -216,14 +218,15 @@
# Setting verbose and condition number options for debugging
geo_model.interpolation_options.kernel_options.compute_condition_number = True


# %%
gp.compute_model(
gempy_model=geo_model,
engine_config=gp.data.GemPyEngineConfig(
backend=gp.data.AvailableBackends.PYTORCH,
dtype='float64'
),
validate_serialization=False
validate_serialization=True
)

# %%
Expand Down
4 changes: 3 additions & 1 deletion gempy/modules/data_manipulation/manipulate_points.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ def add_orientations(geo_model: GeoModel,
elements_names: Sequence[str],
pole_vector: Optional[Union[Sequence[np.ndarray], np.ndarray]] = None,
orientation: Optional[Union[Sequence[np.ndarray], np.ndarray]] = None,
nugget: Optional[Sequence[float]] = None
nugget: Optional[Sequence[float]] = None,
name_id_map: Optional[dict[str, int]] = None #: A mapping between orientation names and ids.
) -> StructuralFrame:
"""Add orientation data to the geological model.

Expand Down Expand Up @@ -176,6 +177,7 @@ def add_orientations(geo_model: GeoModel,
G_z=data['pole_vector'][..., 2],
names=[element_name] * len(data['x']),
nugget=data['nugget'],
name_id_map=name_id_map
)

element: StructuralElement = geo_model.structural_frame.get_element_by_name(element_name)
Expand Down