Skip to content

feat: Update AssessmentLog to include Evidence (ADR-0022)#421

Merged
eddie-knight merged 3 commits into
mainfrom
adr-0022
Jun 13, 2026
Merged

feat: Update AssessmentLog to include Evidence (ADR-0022)#421
eddie-knight merged 3 commits into
mainfrom
adr-0022

Conversation

@eddie-knight

@eddie-knight eddie-knight commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Description

Partially implements ADR-0022. The "address" field is not added in this PR, as I'd like to have some more discussion regarding that field's type.

Schema Changes

Schema Changes Made

  • No schema changes
  • Audit Log schema (auditlog.cue) changes
  • Capability Catalog schema (capabilitycatalog.cue) changes
  • Control Catalog schema (controlcatalog.cue) changes
  • Enforcement Log schema (enforcementlog.cue) changes
  • Evaluation Log schema (evaluationlog.cue) changes
  • Guidance Catalog schema (guidancecatalog.cue) changes
  • Mapping Document schema (mappingdocument.cue) changes
  • Policy Document schema (policy.cue) changes
  • Principle Catalog schema (principlecatalog.cue) changes
  • Risk Catalog schema (riskcatalog.cue) changes
  • Threat Catalog schema (threatcatalog.cue) changes
  • Vector Catalog schema (vectorcatalog.cue) changes
  • Other

Schema Change Details

Modifies #Evidence and makes it an optional field on #AssessmentLog

Testing

  • Unit tests added/updated
  • Manual testing performed
  • Test data updated (if applicable)

Related Issues

Reviewer Hints


Self-review checklist

  • This PR has content that was created with AI assistance.
  • I have the experience and knowledge necessary to answer maintainer questions about the content of this PR, without using AI.

Signed-off-by: Eddie Knight <knight@linux.com>
@eddie-knight eddie-knight requested a review from a team as a code owner June 12, 2026 22:09
@eddie-knight eddie-knight requested a review from jpower432 June 12, 2026 22:09
Comment thread auditlog.cue Outdated
Comment thread auditlog.cue Outdated

@jpower432 jpower432 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggested id be required since we have a list of evidence and asked a question about address.

Co-authored-by: Jennifer Power <jpower@redhat.com>
Co-authored-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
Comment thread test/test-data/good-audit-log.yaml Outdated
Comment thread auditlog.cue Outdated
Co-authored-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
@eddie-knight eddie-knight enabled auto-merge (squash) June 13, 2026 01:30

@hbraswelrh hbraswelrh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddie-knight eddie-knight merged commit c6b47a1 into main Jun 13, 2026
11 checks passed
@eddie-knight eddie-knight deleted the adr-0022 branch June 13, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants