Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for colors, shell safety #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tibers
Copy link

@tibers tibers commented Jan 14, 2021

Fixes:

  • use TTY::Color for seeing if the terminal supports color
  • TTY::Color will also give us how many colors are supported, so it works the same way
  • Remove backticks to prefer ruby native methods. This is much safer since we don't need to know about our shell now.
  • Check process ID with ruby native method

Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant