fix: address issues #50, #51, #53, #54 - #62
Merged
Conversation
gelluisaac
commented
Jul 30, 2026
gelluisaac
commented
Collaborator
- closes SocketManager config defaults get overwritten if config.options exists (merge order bug) #50: fix SocketManager config defaults merge order in constructor
- closes useSocketEvent re-subscribes every render if callback is not stable #51: stabilize useSocketEvent subscription with ref-based callback
- closes Unused type import in useSocket.ts (clean up lint warning) #53: remove unused Socket type import in useSocket.ts
- closes Add automated tests (package.json uses placeholder test script) #54: add Vitest setup and initial tests for SocketManager and useSocket
…bs#54 - gear5labs#50: fix SocketManager config defaults merge order in constructor - gear5labs#51: stabilize useSocketEvent subscription with ref-based callback - gear5labs#53: remove unused Socket type import in useSocket.ts - gear5labs#54: add Vitest setup and initial tests for SocketManager and useSocket
|
@gelluisaac is attempting to deploy a commit to the Fishon Amos' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@gelluisaac Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.