Adding sails DEX #547
Open
Adding sails DEX #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseMedova
requested changes
Jan 8, 2025
There was a problem hiding this comment.
- Gas runs out during transactions that are not atomic. Critical sections, the handle reply hook, and checking the attached gas amount could be used.
- The math is performed simply in integers, which causes quite rough rounding. We could consider using binary math operations (i.e., shifting for multiplication/division).
| *user_liquidity += liquidity; | ||
| } | ||
|
|
||
| let request_a = vft_io::TransferFrom::encode_call(sender, program_id, amount_a); |
There was a problem hiding this comment.
- What will happen if an error occurs during the token transfer, but the state has already been changed earlier?
- What will happen if the gas runs out during the first transfer, between the first and second transfers, or after the second transfer?
|
|
||
| // Transfer token A back to the user | ||
| let request_a = vft_io::TransferFrom::encode_call(program_id, sender, amount_a); | ||
| msg::send_bytes_for_reply(storage.token_a, request_a, 0, 0) |
There was a problem hiding this comment.
The same here.
- The transfer occurs after the state changing
- Running out of gas is a critical issue here
| /// Determines the output token based on `out_is_a`. | ||
| /// Calculates the output amount using the reserves and updates them accordingly. | ||
| /// Transfers the input token to the DEX and the output token to the user. | ||
| pub async fn swap(&mut self, in_amount: U256, out_is_a: bool) { |
There was a problem hiding this comment.
- The state is also changed before the transfers.
- If an error occurs during the second transfer, the tokens will not be returned to the user.
- During the swap, variables affecting the swap price are changed. Therefore, until the swap is fully completed (i.e., until all transfers have occurred), no one should be allowed to perform a swap.
- There is also the issue of running out of gas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.