Skip to content

Conversation

@S-Dafarra
Copy link
Contributor

No description provided.

@S-Dafarra S-Dafarra requested a review from traversaro December 12, 2025 13:49
@S-Dafarra
Copy link
Contributor Author

Actualy, this broke the export on windows. If I look at trintrinTargets.cmake I see

add_library(trintrin::trintrin_msgs SHARED IMPORTED)

while I was expecting

add_library(trintrin::msgs SHARED IMPORTED)

In fact, the test is failing

@traversaro
Copy link
Contributor

ALIAS targets are not installed, so I guess this is expected. If you want to keep the exported target name to be trintrin::msgs and not trintrin::trintrin_msgs, we need to keep the target name to be msgs, and change the output name to be trintrin_msgs to avoid ambiguous file names on the file system. Having said that, I do not understand ho Linux and macOS tests are passing.

@traversaro
Copy link
Contributor

Having said that, I do not understand ho Linux and macOS tests are passing.

Mistery solved, the Install and test installed package check is done only on Windows.

@traversaro
Copy link
Contributor

we need to keep the target name to be msgs, and change the output name to be trintrin_msgs to avoid ambiguous file names on the file system

Basically this means changing back most of the changes in this PR, and add instead:

set_target_properties(msgs PROPERTIES OUTPUT_NAME trintrin_msgs)

@S-Dafarra
Copy link
Contributor Author

Thanks a lot @traversaro, that fixed the issue. Merging and releasing

@S-Dafarra S-Dafarra merged commit 7b49d88 into main Dec 12, 2025
6 checks passed
@traversaro
Copy link
Contributor

@S-Dafarra can we bump the version to 0.1.0 instead of 0.0.2 ? A change in the library name is a ABI breaking change.

@S-Dafarra
Copy link
Contributor Author

@S-Dafarra can we bump the version to 0.1.0 instead of 0.0.2 ? A change in the library name is a ABI breaking change.

Sure! I opened #7

@S-Dafarra S-Dafarra deleted the fix_lib_name branch December 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants