Skip to content

Conversation

@traversaro
Copy link
Contributor

Fix #1267 .

@traversaro
Copy link
Contributor Author

Cool, all test passed, so no test was assuming anything about the default value. @Nicogene @davidegorbani do you want to double check, thanks!

@traversaro traversaro changed the title Set ModelParserOptions::convertThreeRevoluteJointsToSphericalJoint default value to false Set ModelParserOptions::convertThreeRevoluteJointsToSphericalJoint default value to false and bump version to 14.0.2 Nov 7, 2025
@traversaro
Copy link
Contributor Author

I also updated the releases notes in https://github.com/robotology/idyntree/releases/tag/v14.0.0, to clarify that for >=14.0.2 the default behavior is not to convert joints to iDynTree::SphericalJoints by default.

@traversaro traversaro merged commit 464e329 into master Nov 7, 2025
31 checks passed
@traversaro traversaro deleted the fix1267 branch November 7, 2025 09:49
@davidegorbani
Copy link

Thanks!

@Nicogene
Copy link
Contributor

Nicogene commented Nov 7, 2025

Cool, all test passed, so no test was assuming anything about the default value. @Nicogene @davidegorbani do you want to double check, thanks!

After a quick check I would say that I put the explicit option in order to avoid change in the behavior if the default changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set ModelParserOptions::convertThreeRevoluteJointsToSphericalJoint default value back to false

4 participants