Skip to content

Conversation

@Giulero
Copy link
Collaborator

@Giulero Giulero commented Sep 19, 2025

This PR removes --count=100 from
https://github.com/ami-iit/adam/blob/fe457a6f403f6b86e3870553695e0fcc9ec3b584/.github/workflows/conda-forge-tests.yml#L63-L65

For log: this was introduced in #41 (after #38).

Copilot summary

  • Changed workflow and job step names from "ADAM" to "adam" for consistency with project naming conventions. [1] [2]
  • Updated the Windows test command to remove the --count=100 flag from pytest, likely to streamline test execution and avoid redundant runs.

📚 Documentation preview 📚: https://adam-docs--136.org.readthedocs.build/en/136/

Updated the conda-forge workflow to include a nightly build and adjusted pytest command for Windows.
@Giulero Giulero requested review from Copilot and xela-95 September 19, 2025 12:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes repetitive test execution from the Windows CI workflow and standardizes naming conventions. The main change eliminates the --count=100 flag from pytest on Windows, which was causing tests to run 100 times unnecessarily.

  • Removed --count=100 flag from Windows pytest command to avoid redundant test execution
  • Updated workflow and job names from "ADAM" to "adam" for consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Giulero Giulero requested a review from Copilot September 19, 2025 12:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@traversaro
Copy link
Contributor

Yes, I guess this was done to debug a non-deterministic error, it should have never been contained in the final PR, thanks for the catch!

@Giulero Giulero merged commit bff29f0 into main Sep 19, 2025
14 checks passed
@Giulero Giulero deleted the patch-win-conda-ci branch September 19, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants