-
Notifications
You must be signed in to change notification settings - Fork 26
Fix pypi-ci workflow #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pypi-ci workflow #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Python packaging and publishing workflow to align with modern PyPI publishing best practices, focusing on improved build configuration and streamlined CI/CD processes.
- Updated build system requirements to use newer versions of setuptools and setuptools_scm
- Simplified workflow triggers and restructured job dependencies for better clarity
- Removed GitHub Release signing and publishing functionality to focus solely on PyPI publishing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Updated build system requirements and added setuptools_scm configuration for versioning |
| .github/workflows/pypi-ci.yml | Restructured workflow triggers, simplified job dependencies, and removed GitHub Release job |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Publish Python 🐍 distribution 📦 to PyPI | ||
| name: Publish Python 🐍 distribution 📦 to PyPI | ||
| needs: build | ||
| if: github.event_name == 'release' || startsWith(github.ref, 'refs/tags/') |
Copilot
AI
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition startsWith(github.ref, 'refs/tags/') will never be true since the workflow no longer triggers on tag pushes. The workflow only triggers on release events, pull requests, and workflow dispatch. Consider removing this redundant condition.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request updates the Python packaging and publishing workflow, aligning it with https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
Copilot summary
CI/CD Workflow Improvements:
.github/workflows/pypi-ci.ymlworkflow triggers, ensuring builds run on release, pull request, and workflow dispatch events, and made event types more explicit.dist, set explicit job dependencies usingneeds, and improved artifact download/upload steps for consistency across jobs.github-releasejob that signed distributions with Sigstore and uploaded them to GitHub Releases, focusing the workflow solely on PyPI and TestPyPI publishing.Build System and Publishing Enhancements:
pyproject.tomlto require newer versions ofsetuptoolsandsetuptools_scm, and removed legacy/duplicate requirements, ensuring compatibility with modern Python packaging standards.verbose: trueandskip-existing: trueoptions to the TestPyPI publishing step, improving feedback and avoiding re-upload errors for existing distributions.Configuration Improvements:
[tool.setuptools_scm]section topyproject.tomlto specifylocal_scheme = "dirty-tag", which controls versioning for local builds.📚 Documentation preview 📚: https://adam-docs--135.org.readthedocs.build/en/135/