Skip to content

Conversation

@Giulero
Copy link
Collaborator

@Giulero Giulero commented Sep 15, 2025

This pull request updates the Python packaging and publishing workflow, aligning it with https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

Copilot summary

CI/CD Workflow Improvements:

  • Simplified and restructured the .github/workflows/pypi-ci.yml workflow triggers, ensuring builds run on release, pull request, and workflow dispatch events, and made event types more explicit.
  • Refactored job dependencies and artifact naming: standardized the artifact name to dist, set explicit job dependencies using needs, and improved artifact download/upload steps for consistency across jobs.
  • Removed the github-release job that signed distributions with Sigstore and uploaded them to GitHub Releases, focusing the workflow solely on PyPI and TestPyPI publishing.

Build System and Publishing Enhancements:

  • Updated pyproject.toml to require newer versions of setuptools and setuptools_scm, and removed legacy/duplicate requirements, ensuring compatibility with modern Python packaging standards.
  • Added verbose: true and skip-existing: true options to the TestPyPI publishing step, improving feedback and avoiding re-upload errors for existing distributions.

Configuration Improvements:

  • Added a [tool.setuptools_scm] section to pyproject.toml to specify local_scheme = "dirty-tag", which controls versioning for local builds.

📚 Documentation preview 📚: https://adam-docs--135.org.readthedocs.build/en/135/

@Giulero Giulero requested a review from Copilot September 15, 2025 16:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Python packaging and publishing workflow to align with modern PyPI publishing best practices, focusing on improved build configuration and streamlined CI/CD processes.

  • Updated build system requirements to use newer versions of setuptools and setuptools_scm
  • Simplified workflow triggers and restructured job dependencies for better clarity
  • Removed GitHub Release signing and publishing functionality to focus solely on PyPI publishing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updated build system requirements and added setuptools_scm configuration for versioning
.github/workflows/pypi-ci.yml Restructured workflow triggers, simplified job dependencies, and removed GitHub Release job

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Publish Python 🐍 distribution 📦 to PyPI
name: Publish Python 🐍 distribution 📦 to PyPI
needs: build
if: github.event_name == 'release' || startsWith(github.ref, 'refs/tags/')
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition startsWith(github.ref, 'refs/tags/') will never be true since the workflow no longer triggers on tag pushes. The workflow only triggers on release events, pull requests, and workflow dispatch. Consider removing this redundant condition.

Copilot uses AI. Check for mistakes.
@Giulero Giulero requested a review from Copilot September 18, 2025 07:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Giulero Giulero merged commit 7bd8e87 into main Sep 18, 2025
5 of 13 checks passed
@Giulero Giulero deleted the fix-pypi-ci branch September 18, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants