-
Notifications
You must be signed in to change notification settings - Fork 27
Add InverseKinematics class #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
05b708e
Add InverseKinematics class
Giulero 2c206e3
Refactor: Introduce Target class and add some documentation
Giulero 4943741
Update type hints
Giulero b27ab28
Add liecasadi to dependencies in ci_env.yml, ci_env_win.yml, and pypr…
Giulero 2e908d0
Small fix
Giulero 309161f
Add methods for retrieving Opti and KinDynComputations objects. Add m…
Giulero 856e589
Import TargetType
Giulero eacccf1
Replace mamba with conda in installation instructions for consistency
Giulero 65aa1db
Add Inverse Kinematics interface using CasADi with example usage
Giulero 282bae5
Update src/adam/casadi/inverse_kinematics.py
Giulero 7b09c36
Update src/adam/casadi/inverse_kinematics.py
Giulero ca8aeed
Modify argument in constraint to highlight the possibility to set it …
Giulero 9b558e7
Refactor rotation error calculation
Giulero d904681
Update src/adam/casadi/inverse_kinematics.py
Giulero 0e1299e
Update src/adam/casadi/inverse_kinematics.py
Giulero 74d1801
Update example
Giulero e895012
Use as_soft_constraint also in the targets
Giulero 6c3c5bc
Update readme with as_soft_constraint
Giulero 2d957b1
Update src/adam/casadi/inverse_kinematics.py
Giulero c1ff75b
Update src/adam/casadi/inverse_kinematics.py
Giulero 636d134
Clarify documentation for as_soft_constraint parameter in InverseKine…
Giulero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,3 +20,4 @@ dependencies: | |
| - pytorch | ||
| - jax2torch | ||
| - requests | ||
| - liecasadi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,4 @@ dependencies: | |
| - icub-models | ||
| - idyntree >=11.0.0 | ||
| - requests | ||
| - liecasadi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can it not a constraint if I am calling it with
add_ball_constraint? We historically had a huge confusion between constraints and tasks in iDynTree, but probably we can try to avoid it here, for example using a different term (as_optimization_constraintor something similar?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
What do you think about something like
ik.add_ball_constraint(frame_1, frame_2, as_soft_constraint=True)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but probably we may want to have an argument with a similar name in
add_targetto avoid confusion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could add to the
add_targetmethod an input calledas_soft_constraintas well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to