Skip to content

Refactor path handling in get_xml_string to simplify OS-specific checks #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Giulero merged 1 commit into from
Mar 12, 2025
Merged

Refactor path handling in get_xml_string to simplify OS-specific checks #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/adam/model/std_factories/std_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,10 @@ def get_xml_string(path: str | pathlib.Path):
isPath = isinstance(path, pathlib.Path)
isUrdf = False

# Extract the maximum path length for the current OS
try:
from ctypes.wintypes import MAX_PATH
except ValueError:
MAX_PATH = os.pathconf("/", "PC_PATH_MAX")

# Checking if it is a path or an urdf
if not isPath:
if len(path) <= MAX_PATH and "<robot" not in path:
path = pathlib.Path(path)
if "<robot" not in path:
path = pathlib.Path(path).resolve()
isPath = True
else:
root = ET.fromstring(path)
Expand Down
Loading