Refactor gravity parameter initialization and update post-init array conversion to use default dtype #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conversion to use default dtype
Collaborator
Author
|
CI fixed! |
GiulioRomualdi
force-pushed
the
fix_float64
branch
from
078ffad to
7def711
Compare
Collaborator
Author
|
I modified the code so there is no need to update the tests :) |
Giulero
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of data types and default values in the
adampackage. The most important changes include updates to the initialization methods in two computation files and modifications to theTorchLikeclass to use the default tensor type.Improvements to initialization methods:
src/adam/parametric/pytorch/computations_parametric.py: Simplified thegravityparameter in the__init__method by removing the explicitdtypespecification.src/adam/pytorch/computations.py: Simplified thegravityparameter in the__init__method by removing the explicitdtypespecification.Enhancements to
TorchLikeclass:src/adam/pytorch/torch_like.py: Modified the__post_init__method to convert the array to the default tensor type instead of always converting to double precision.📚 Documentation preview 📚: https://adam-docs--124.org.readthedocs.build/en/124/