Skip to content

Conversation

@traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 20, 2024

Copy link
Collaborator

@Giulero Giulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @traversaro!

@Giulero
Copy link
Collaborator

Giulero commented Nov 20, 2024

Feel free to merge :)

@traversaro
Copy link
Contributor Author

Feel free to merge :)

I guess typically the maintainers of the repo merge the PR? No problems of merging on my side, I just want to avoid giving any wrong idea to anyone, as most AMI members have write permission on the code repos, and nevertheless we typically let mantainers merge the PRs on the repos they maintain.

@Giulero
Copy link
Collaborator

Giulero commented Nov 21, 2024

Yeah @traversaro, you're right!
Merging then :)

@Giulero Giulero merged commit 8cd3cb1 into main Nov 21, 2024
16 checks passed
@traversaro traversaro deleted the traversaro-patch-2 branch November 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants