Skip to content

Raise error if a non-existing string-type path is passed #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Giulero merged 2 commits into from
Nov 18, 2024
Merged

Raise error if a non-existing string-type path is passed #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8adde6
Raise error if a non-existing string-type path is passed
flferretti Nov 4, 2024
53cbe10
Add additional check on path existance
flferretti Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/adam/model/std_factories/std_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def get_xml_string(path: str | pathlib.Path):

# Checking if it is a path or an urdf
if not isPath:
if len(path) <= MAX_PATH and os.path.exists(path):
if len(path) <= MAX_PATH and "<robot" not in path:
path = pathlib.Path(path)
isPath = True
else:
Expand All @@ -49,11 +49,7 @@ def get_xml_string(path: str | pathlib.Path):
break

if isPath:
if not path.is_file():
raise FileExistsError(path)

with path.open() as xml_file:
xml_string = xml_file.read()
xml_string = path.read_text()

if not isPath and not isUrdf:
raise ValueError(
Expand Down