Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LDH with $00-$FF #1575

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Deprecate LDH with $00-$FF #1575

merged 1 commit into from
Dec 11, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Dec 9, 2024

Fixes #1570

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM rgblink This affects RGBLINK labels Dec 9, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Dec 9, 2024
@Rangi42 Rangi42 requested a review from ISSOtm December 9, 2024 18:25
@Rangi42
Copy link
Contributor Author

Rangi42 commented Dec 9, 2024

Note that gbz80(7) already documents these instructions as "provided the address is between $FF00 and $FFFF", without mentioning the $00 to $FF possibility.

ISSOtm
ISSOtm approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour me surprised if anyone actually relies on this!

@Rangi42 Rangi42 merged commit c1c5b10 into gbdev:master Dec 11, 2024
22 checks passed
@Rangi42 Rangi42 deleted the deprecate-ldh-xx branch December 11, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM rgblink This affects RGBLINK
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Deprecate ldh [$xx]
2 participants
@Rangi42 @ISSOtm