-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate LDIO
#1567
Deprecate LDIO
#1567
Conversation
Frankly it might be simpler to just remove, since that would let people do a one-line (The poll has zero votes for using |
Unpopular opinion... Too much deprecation. I say just remove it, and let the assembler errors notify people they need to update their code. It's a simple replace anyways.. I know lots of people who ignore those deprecation warnings until a release causes it to stop building... And then they might just stay on the old version anyways. Prepares for incoming rant :P |
Just to note, re: allowing multiple alternatives in general, we already do so for |
So far 13 votes to deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, ldio
is uncontroversial enough, so let's act it out. We'll see about the other syntax in a separate thread.
Oops, that was actually a good point, I think. Hmm, well, the main reason we're using deprecation warnings is to provide a nicer error message, so people who do upgrade are less confused and lost than getting a generic |
I already expect the results of our polls will be to deprecate
ldio [...]
but notld [$ff00+...]
, so went ahead and implemented it in what should be an efficient way.(In the test case, I know
ld [$ff11], a
andld a, [$ff11]
assemble to different opcodes than the rest; they're just there for completeness, and they illustrate b0495b3.)