Skip to content

BUG: make time type string [s ns] #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2021
Merged

BUG: make time type string [s ns] #662

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
293ff29
BUG: make time type string [s ns]
FirefoxMetzger Aug 10, 2021
32106af
FEAT: collapse whitespace
FirefoxMetzger Aug 10, 2021
849727b
Merge branch 'sdf11' into fix-time
jennuine Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdf/1.5/schema/types.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
</xsd:simpleType>

<xsd:simpleType name="time">
<xsd:restriction base="xsd:double">
<xsd:restriction base="xsd:string">
<xsd:pattern value="\d+ \d+"/>
Copy link
Collaborator

@jennuine jennuine Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the others as well

Suggested change
<xsd:pattern value="\d+ \d+"/>
<xsd:pattern value="\s*\d+\s+\d+\s*"/>

Copy link
Contributor Author

@FirefoxMetzger FirefoxMetzger Aug 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennuine Hm, if we are worried about whitespace, wouldn't something like this be a bit more readable?

<xsd:restriction base="xsd:string">
  <xsd:whiteSpace value="collapse"/>
  <xsd:pattern value="\d+ \d+"/>
</xsd:restriction>

Copy link
Collaborator

@jennuine jennuine Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

Copy link
Contributor Author

@FirefoxMetzger FirefoxMetzger Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennuine Done.

</xsd:restriction>
</xsd:simpleType>

Expand Down
3 changes: 2 additions & 1 deletion sdf/1.6/schema/types.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
</xsd:simpleType>

<xsd:simpleType name="time">
<xsd:restriction base="xsd:double">
<xsd:restriction base="xsd:string">
<xsd:pattern value="\d+ \d+"/>
</xsd:restriction>
</xsd:simpleType>

Expand Down
3 changes: 2 additions & 1 deletion sdf/1.7/schema/types.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
</xsd:simpleType>

<xsd:simpleType name="time">
<xsd:restriction base="xsd:double">
<xsd:restriction base="xsd:string">
<xsd:pattern value="\d+ \d+"/>
</xsd:restriction>
</xsd:simpleType>

Expand Down
3 changes: 2 additions & 1 deletion sdf/1.8/schema/types.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
</xsd:simpleType>

<xsd:simpleType name="time">
<xsd:restriction base="xsd:double">
<xsd:restriction base="xsd:string">
<xsd:pattern value="\d+ \d+"/>
</xsd:restriction>
</xsd:simpleType>

Expand Down