Repository navigation
chore: commit every shell script as 100755 - #161
Merged
Merged
Conversation
Two of the seven tracked scripts were 100644 while their siblings were 100755, with no rule separating them. All seven have a shebang, and the sandbox template bind-mounts init-firewall.sh and executes it by path, so the exec bit is the correct default. Record the rule in CLAUDE.md. Fixes #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets the exec bit on the two shell scripts committed as
100644and records a rule in.claude/CLAUDE.md, so all seven tracked.shfiles are100755.Why
Two scripts (
claude-bun/.devcontainer/init-firewall.sh,claude-code/.devcontainer/init-plugins.sh) were644, while their counterparts in sibling directories were755. No rule explained the split, and #125 flipped the two files without anyone noticing.755is the right rule, not just the majority:claude-code/.devcontainer/claude-sandbox/devcontainer.jsonbind-mounts the project'sinit-firewall.shto/usr/local/bin/init-firewall.shand runs it by path (sudo /usr/local/bin/init-firewall.sh). A bind mount keeps the host file's mode.Changes
claude-bun/.devcontainer/init-firewall.sh:100644 → 100755claude-code/.devcontainer/init-plugins.sh:100644 → 100755.claude/CLAUDE.mdCode Style: added the rule and the one-line check (git ls-files -s '*.sh')Notes
COPYs the script and then runschmod +x. Thebuild-claude-bun.ymlpath filter will still trigger a rebuild, and the resulting image will be byte-identical.Fixes #127