fix: preserve BrowseList selection during polling#27
Open
KalleBylin wants to merge 2 commits intogastownhall:mainfrom
Open
fix: preserve BrowseList selection during polling#27KalleBylin wants to merge 2 commits intogastownhall:mainfrom
KalleBylin wants to merge 2 commits intogastownhall:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #17. During review there, a remaining BrowseList issue was called out as a good follow-up: background polling did not start after the first successful load, and when polling ran later it dropped the current selection.
What changed
Local verification
Checked locally with the web test suite and frontend checks.
web run checkstill reports the existingBrowseList.module.cssdescending-specificity warning, unchanged by this PR.