fix: sling retry noise, convoy cross-rig routing, mail error detection#3511
Open
maloferriol wants to merge 2 commits intogastownhall:mainfrom
Open
fix: sling retry noise, convoy cross-rig routing, mail error detection#3511maloferriol wants to merge 2 commits intogastownhall:mainfrom
maloferriol wants to merge 2 commits intogastownhall:mainfrom
Conversation
1. SetAgentStateWithRetry: reduce retries from 10 (2min) to 3 (3.5s). Agent state is monitoring-only; caller already treats errors as warn-only. Avoids blocking interactive `gt sling` on persistent Dolt failures. (hq-bfp7, hq-htfi) 2. bdListChildren: use resolveBeadDir instead of beadsDirForID. The latter returns the .beads directory itself, causing bd to look for .beads/.beads/ which doesn't exist. Also strip BEADS_DIR from env, consistent with bdShow/bdDepList. (hq-db5) 3. createStagedConvoy: replace raw exec.Command with BdCmd builder using Dir()+StripBeadsDir(), preventing inherited BEADS_DIR from routing bd to the wrong database. (hq-db5) Co-Authored-By: Claude Opus 4.6 <[email protected]> Executed-By: mayor
bd returns "no issue found matching" for missing beads, but the mail package only checked for "not found" substring. This prevented the cross-rig fallback from triggering when looking up wisps (sh-wisp-*) that route to shipyard but live in hq. Add "no issue found" as an additional match pattern in all ContainsError checks across mailbox.go and delivery.go. Co-Authored-By: Claude Opus 4.6 <[email protected]> Executed-By: mayor
github-actions
bot
added
the
status/needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetAgentStateWithRetryfrom 10 retries (~2min) to 3 (~3.5s). Agent state is monitoring-only; caller treats errors as warn-only.bdListChildrento useresolveBeadDir(returns parent of .beads) instead ofbeadsDirForID(returns .beads itself, causing bd to look for .beads/.beads/). Also strip BEADS_DIR and fix raw exec.Command increateStagedConvoy.ContainsErrorchecks. bd returns "no issue found matching" but mail only checked for "not found", preventing cross-rig wisp fallback from triggering.Test plan
bd show sh-wisp-xxxworks from both town and shipyard contextsgt mail read sh-wisp-xxxreturns wisp contentbd createfrom town root generateshq-prefix (notsh-)bd show,bd closework for both prefixesgt convoy create --from-epicwith cross-rig dependenciesgt slingcompletes without 2-minute retry delay🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 [email protected]