fix(daemon): deduplicate Dolt alerts and use nudge instead of full restart#3488
Open
jw409 wants to merge 1 commit intogastownhall:mainfrom
Open
fix(daemon): deduplicate Dolt alerts and use nudge instead of full restart#3488jw409 wants to merge 1 commit intogastownhall:mainfrom
jw409 wants to merge 1 commit intogastownhall:mainfrom
Conversation
- Add doltAlertTracker with fingerprint-based cooldowns (5min) to prevent wisp storms during Dolt crash loops - Switch sendCrashAlert and sendUnhealthyAlert from gt mail send to gt nudge (ephemeral, zero-cost — no Dolt commit per alert) - Keep escalation on gt mail send (must survive session death) with --wisp-type escalation tag - Remove witness mail fan-out; witnesses detect degraded state via DOLT_UNHEALTHY signal file instead - Reset alert tracker when backoff resets after healthy period - Fix wispTypeToCategory test to match current 2-arg signature - Add nolint:misspell annotations for bead ID references (gt-ect) - Fix serialised → serialized typo in convoy_manager Fixes gastownhall#3474
github-actions
bot
added
the
status/needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doltAlertTrackerwith fingerprint-based cooldowns (5 min) to prevent wisp storms during Dolt crash loopssendCrashAlertandsendUnhealthyAlertfromgt mail send(permanent Dolt commit) togt nudge(ephemeral, zero cost)gt mail sendwith--wisp-type escalationtag — escalations must survive session deathDOLT_UNHEALTHYsignal filewispTypeToCategorytest to match current 2-arg signaturenolint:misspellannotations for bead ID references (gt-ect)serialised→serializedtypo inconvoy_manager.goFollows the communication hygiene principle: mail only for messages that must survive session death.
Fixes #3474
Test plan
🇺🇸 Reid Wiseman — Commander
🇺🇸 Victor Glover — Pilot
🇺🇸 Christina Koch — Mission Specialist
🇨🇦 Jeremy Hansen — Mission Specialist
Artemis II. Open source for all — on this planet and beyond it.