fix: keep daemon Dolt verification in TCP client mode#3482
Open
Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Open
fix: keep daemon Dolt verification in TCP client mode#3482Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Conversation
Author
|
Follow-up note: the remaining VerifyServerDataDir fallback path that still queried SHOW DATABASES through the older local helper is now addressed separately in #3485, so this PR can stay scoped to the daemon helper only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildDoltSQLCmdhelper to always use explicit TCP client modeDOLT_CLI_PASSWORDonly for remote checks when config does not specify a passwordWhy
PR #3470 fixed the shared
internal/doltserverhelper but intentionally left the daemon mirror helper unchanged.That left daemon health, write-probe, and identity-query shellouts able to use the older helper behavior. This PR brings the daemon helper to the same explicit TCP/non-interactive model without broadening into unrelated Dolt verification cleanup.
Validation
GOTOOLCHAIN=auto go test -c ./internal/daemonGOTOOLCHAIN=auto go test ./internal/doltserver -run 'TestBuildDoltSQLCmd.*|TestCheckServerReachable.*|TestIsRunning.*'Notes
internal/doltserver.VerifyServerDataDirfallback path still needs the same explicit-TCP cleanup in a separate change.