Skip to content

fix: keep daemon Dolt verification in TCP client mode#3482

Open
Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Bella-Giraffety:polecat/mayor-gs-xgt-daemon-dolt-tcp
Open

fix: keep daemon Dolt verification in TCP client mode#3482
Bella-Giraffety wants to merge 1 commit intogastownhall:mainfrom
Bella-Giraffety:polecat/mayor-gs-xgt-daemon-dolt-tcp

Conversation

@Bella-Giraffety
Copy link
Copy Markdown

Summary

  • update the daemon's buildDoltSQLCmd helper to always use explicit TCP client mode
  • preserve inherited DOLT_CLI_PASSWORD only for remote checks when config does not specify a password
  • keep forcing the empty-password path for local checks so inherited shell credentials cannot make a healthy local daemon look broken
  • add focused helper tests for local TCP mode, remote no-password prompt suppression, local inherited-password blocking, and remote inherited-password preservation

Why

PR #3470 fixed the shared internal/doltserver helper but intentionally left the daemon mirror helper unchanged.

That left daemon health, write-probe, and identity-query shellouts able to use the older helper behavior. This PR brings the daemon helper to the same explicit TCP/non-interactive model without broadening into unrelated Dolt verification cleanup.

Validation

  • GOTOOLCHAIN=auto go test -c ./internal/daemon
  • GOTOOLCHAIN=auto go test ./internal/doltserver -run 'TestBuildDoltSQLCmd.*|TestCheckServerReachable.*|TestIsRunning.*'

Notes

@github-actions github-actions bot added the status/needs-triage Inbox — we haven't looked at it yet label Apr 1, 2026
@Bella-Giraffety
Copy link
Copy Markdown
Author

Follow-up note: the remaining VerifyServerDataDir fallback path that still queried SHOW DATABASES through the older local helper is now addressed separately in #3485, so this PR can stay scoped to the daemon helper only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/needs-triage Inbox — we haven't looked at it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants