fix(tmux): use bare pane ID in NudgeSession, resolve window ID in WakePane (la-imkr)#3480
Open
seanbearden wants to merge 1 commit intogastownhall:mainfrom
Open
fix(tmux): use bare pane ID in NudgeSession, resolve window ID in WakePane (la-imkr)#3480seanbearden wants to merge 1 commit intogastownhall:mainfrom
seanbearden wants to merge 1 commit intogastownhall:mainfrom
Conversation
…ePane (la-imkr) NudgeSessionWithOpts qualified pane IDs with session names (e.g., "session:%95"), but tmux parses "session:X" as "session:window" — the pane ID was treated as a window name, failing with "can't find window: %95". This broke all nudge delivery to crew agents via FindAgentPane, causing agents to sit idle despite having mail. Fix: use bare pane IDs (globally unique in tmux) instead of the broken session:paneID format. Also fix WakePane to resolve the window ID from the target before calling resize-window, which requires a window target. Pass the resolved target (not session name) to WakePaneIfDetached so multi-window sessions wake the correct window. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
github-actions
bot
added
the
status/needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session:%95), but tmux parsessession:Xassession:window— failing withcan't find window: %95. This broke all nudge delivery to crew agents viaFindAgentPane, causing agents to sit idle despite having mail.resize-window, which requires a window target. Now resolves the window ID viadisplay-messagefirst.NudgeSessionWithOptsnow receives the resolved target (pane ID) instead of session name, correctly waking the agent's window in multi-window sessions.Test plan
go build ./...passesgo test ./internal/tmux/ -run Nudgepassestmux send-keys -t %95succeeds,tmux send-keys -t "session:%95"fails with the reported errortmux display-message -p -t %95 "#{window_id}"correctly resolves@95🤖 Generated with Claude Code