feat(formula): add --set flag and fix bead prefix for convoy formulas#3276
Closed
ckumar1 wants to merge 1 commit intogastownhall:mainfrom
Closed
feat(formula): add --set flag and fix bead prefix for convoy formulas#3276ckumar1 wants to merge 1 commit intogastownhall:mainfrom
ckumar1 wants to merge 1 commit intogastownhall:mainfrom
Conversation
Two bugs in executeConvoyFormula found by Krieger (qc-dcj1): 1. No mechanism to pass [inputs] values to convoy formulas. gt formula run only accepted --pr and --files, so convoy formulas needing free-form inputs (design, mol-prd-review) had no working execution path. Added --set key=value flag that injects user-defined variables into the template context for both execution and dry-run modes. 2. Convoy/leg/synthesis beads were created with hq- prefix (town root) but gt sling dispatches to the target rig, which rejects mismatched prefixes. Now uses config.GetRigPrefix() to resolve the rig's actual beads prefix. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Executed-By: gastown/crew/woodhouse
Contributor
Author
|
Friendly ping — is this approach heading in the right direction? Happy to adjust if the --set flag design or bead prefix fix doesn't fit the project's direction. Let us know if you'd prefer this structured differently. |
Contributor
Author
|
Superseded by #3497 (same fix, cleaner cherry-pick from carry/operational). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--set key=valueflag togt formula runfor passing input variables to convoy formulasexecuteConvoyFormulaused hard-codedhq-prefix; now resolves viaconfig.GetRigPrefix()to match the target rigContext
Convoy formulas define
[inputs]in their TOML (e.g.,problem,context,scope) butgt formula runhad no mechanism to pass values for them. The only parameterization was--prand--files. Formulas likedesignandmol-prd-reviewthat need--problemhad no working execution path.Separately, convoy/leg/synthesis beads were created with
hq-prefix (town root) butgt slingdispatches to the target rig, which rejects mismatched prefixes.Usage
Test plan
go build ./cmd/gtgo vet ./internal/cmd/--setvalues injected into template context for both execution and dry-runhq-🤖 Generated with Claude Code