fix: /ship CHANGELOG and PR body now cover all branch commits (v0.12.4.0)#535
Merged
fix: /ship CHANGELOG and PR body now cover all branch commits (v0.12.4.0)#535
Conversation
Step 5 (CHANGELOG generation) restructured to force explicit commit enumeration, theme grouping, and cross-check before writing. Step 8 (PR body) changed from "bullet points from CHANGELOG" to commit-by-commit coverage with logical sections. Fixes recency bias that dropped early commits on long branches.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CHANGELOG.md conflict: both sides used v0.12.3.0. Kept main's voice directive entry as v0.12.3.0, bumped our commit coverage fix to v0.12.4.0. Regenerated all SKILL.md files to incorporate both our ship template changes (Step 5/8 commit coverage) and main's voice directive feature (preamble.ts resolver additions).
E2E Evals: ✅ PASS9/9 tests passed | $.75 total cost | 12 parallel runners
12x ubicloud-standard-2 (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite |
garrytan
changed the title
KimYoungHwan8750
pushed a commit
to KimYoungHwan8750/gstack-ko
that referenced
this pull request
Mar 27, 2026
…4.0) (garrytan#535) * fix: /ship CHANGELOG and PR body now cover all branch commits Step 5 (CHANGELOG generation) restructured to force explicit commit enumeration, theme grouping, and cross-check before writing. Step 8 (PR body) changed from "bullet points from CHANGELOG" to commit-by-commit coverage with logical sections. Fixes recency bias that dropped early commits on long branches. * chore: bump version and changelog (v0.12.3.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
rapidstartup
pushed a commit
to rapidstartup/gstack
that referenced
this pull request
Mar 29, 2026
…4.0) (garrytan#535) * fix: /ship CHANGELOG and PR body now cover all branch commits Step 5 (CHANGELOG generation) restructured to force explicit commit enumeration, theme grouping, and cross-check before writing. Step 8 (PR body) changed from "bullet points from CHANGELOG" to commit-by-commit coverage with logical sections. Fixes recency bias that dropped early commits on long branches. * chore: bump version and changelog (v0.12.3.0) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHANGELOG/PR coverage bug fix. When shipping a branch with many commits spanning multiple themes (e.g., performance + dead code removal + test infra), the CHANGELOG and PR summary biased toward recent commits and silently dropped earlier work. Found on the
garrytan/post-gen-perfbranch where 8 of 12 commits were missing from the PR body.Two changes:
Test Coverage
No application code paths changed. This is a prompt template text fix (
ship/SKILL.md.tmpland its generatedship/SKILL.md). Existingbun testsuite passes (skill validation, gen-skill-docs quality checks).A P3 TODO was added for a multi-commit E2E eval that would exercise this failure mode.
Pre-Landing Review
No issues found. Pure markdown/prose changes to skill templates.
TODOS
Test plan
bun testpasses (skill validation + gen-skill-docs quality)ship/SKILL.mdmatches template changes🤖 Generated with Claude Code