Merged
Conversation
For some reason an input with type="file" has a height of 4px. https://github.com/grafana/grafana/blob/01ec8e3a4aa74ae730281876031a2a97f85bf2cb/packages/grafana-data/src/themes/createComponents.ts#L90 https://github.com/grafana/grafana/blob/0c016e210ad39502253e02f35c65ff6721eb0736/packages/grafana-ui/src/themes/GlobalStyles/forms.ts#L38 Now uses the FileUpload component which has a normal height :D
ZuperZee
added a commit
that referenced
this pull request
Nov 5, 2025
The first attempt was: #210 but it had an annoying issue with the edit panel being shrunk after clicking the file upload button. Now just use the normal input element... :(
ZuperZee
added a commit
that referenced
this pull request
Nov 5, 2025
The first attempt was: #210 but it had an annoying issue with the edit panel being shrunk after clicking the file upload button. Now just use the normal input element... :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason an input with type="file" has a height of 4px. https://github.com/grafana/grafana/blob/01ec8e3a4aa74ae730281876031a2a97f85bf2cb/packages/grafana-data/src/themes/createComponents.ts#L90 https://github.com/grafana/grafana/blob/0c016e210ad39502253e02f35c65ff6721eb0736/packages/grafana-ui/src/themes/GlobalStyles/forms.ts#L38
Now uses the FileUpload component which has a normal height :D
Before (long tiny 4px button):
After:
