feat: add adjustable height for the code editor#206
Merged
Conversation
The height is adjusted with the "resize" css style. Most browsers support it, but some, like Safari, do not. The default height is also lowered to 64px mainly to make scrolling easier. I also found it a lot easier to get an overview and navigate through the options with the smaller editor height :D
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller View module informationAdded
Removed No modules were removed Bigger
Smaller No modules were smaller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The height is adjusted with the "resize" css style. Most browsers support it, but some, like Safari, do not.
The default height is also lowered to 64px mainly to make scrolling easier.
I also found it a lot easier to get an overview and navigate through the options with the smaller editor height :D
Isn't exactly what's asked in #179, but does make it easier to scroll passed the onRender block, so I will consider it solves the same problem.
Closes #179