feat: don't wait for declarations to load editor#203
Merged
Conversation
Start loading the editor immediately instead of waiting for the type declarations to be fetched. The editor can still be used when the declarations are not yet loaded, but the type declarations are loaded pretty quick, so it shouldn't be noticeable. This has kinda the same problems as #202 since this uses dynamic updating of type declarations. Straight copied from the commit message: This only works for Grafana v8.2.0-v8.3.X and v9.2.0 and later. Grafana v8.4.0 updated monaco editor to v0.31.1 which had a bug which prevents dynamically updating type declarations. This was fixed in Grafana v9.2.0.
ZuperZee
deleted the
zuperzee/do-not-wait-for-declarations-to-load-editor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start loading the editor immediately instead of waiting for the type declarations to be fetched.
The editor can still be used when the declarations are not yet loaded, but the type declarations are loaded pretty quick, so it shouldn't be noticeable.
This has kinda the same problems as #202 since this uses dynamic updating of type declarations.
Straight copied from the commit message:
This only works for Grafana v8.2.0-v8.3.X and v9.2.0 and later. Grafana v8.4.0 updated monaco editor to v0.31.1 which had a bug which prevents dynamically updating type declarations. This was fixed in Grafana v9.2.0.