Merged
Conversation
Bundle Size ChangesHello! 👋 This comment was generated by a Github Action to help you and reviewers understand the impact of your PR on frontend bundle sizes. Whenever this PR is updated, this comment will update to reflect the latest changes.
View detailed bundle informationAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller View module informationAdded No modules were added Removed No modules were removed Bigger
Smaller No modules were smaller |
Replaces the old deprecated CustomScrollbar with the new ScrollContainer component from Grafana. The new ScrollContainer only works with Grafana 11.5.0 or later. Older versions of Grafana will still use the old CustomScrollbar.
ZuperZee
force-pushed
the
zuperzee/add-new-scroll-container
branch
from
85108c4 to
9c05e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the old deprecated CustomScrollbar with the new ScrollContainer component from Grafana.
The new ScrollContainer only works with Grafana 11.5.0 or later.
Older versions of Grafana will still use the old CustomScrollbar.
Before:
After:
Kinda hard to decide if this is a breaking change or not.
There isn't any breaking API, behavior, or functionality change, but the new ScrollContainer component does add some shading/gradient to the top and bottom of the container when scrolled.
This would require some CSS/options to be changed for users of the plugin to remove the shading.
The ScrollContainer is also the default, which might make older panels have an unwanted shading.