Skip to content

fix: make the on-call add/edit dialog usable #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbgap merged 2 commits into from
Apr 27, 2026
Merged

fix: make the on-call add/edit dialog usable #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6860b0
fix: make date-edit clearable
sbgap Apr 27, 2026
f7db3d9
fix: fix name for repeat months field in on-call-add dialog
sbgap Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/DateEdit.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
prepend-inner-icon="calendar_month"
:disabled="disabled"
:placeholder="placeholder ?? label"
clearable
@click:clear="editDate = null"
/>
</template>

Expand All @@ -20,7 +22,7 @@
import moment from 'moment'
import {computed, ref, watch} from 'vue'

const value = defineModel<string>()
const value = defineModel<string | null>()

const componentProps = defineProps<{
disabled?: boolean
Expand All @@ -33,7 +35,7 @@ const componentProps = defineProps<{
const editDate = ref<string | null>(value.value == '' ? null : (value.value ?? null))
const menu = ref(false)
const editedDate = computed(() => {
if (editDate.value === null && !componentProps.newDate) return ''
if (editDate.value === null && !componentProps.newDate) return null
return moment(editDate.value).format('YYYY-MM-DD')
})

Expand Down
8 changes: 1 addition & 7 deletions src/components/dialogs/add/OnCallAdd.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,7 @@
</v-col>

<v-col cols="12" class="pb-0">
<g-combobox
v-model="editedItem.repeatMonths"
multiple
show-header
:items="months"
:label="t('EndTime')"
/>
<g-combobox v-model="editedItem.repeatMonths" multiple show-header :items="months" :label="t('Months')" />
</v-col>
</v-row>
</v-card-text>
Expand Down
Loading