Skip to content

Commit

Permalink
tests: add comments on broken tests
Browse files Browse the repository at this point in the history
... explaining what was broken at the time they were marked as broken.
That is helpful when trying to later on figure out if they are still
broken or not.
  • Loading branch information
fingolfin committed Jan 21, 2025
1 parent 28ab734 commit c51e2ad
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tst/standard/ClassicalNormalizerMatrixGroups.tst
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ gap> TestOrthogonalInSp := function(epsilon, n, q)
> CheckSize(G);
> end;;
#@if IsBound(CLASSICAL_MAXIMALS_RUN_BROKEN_TESTS)
gap> TestOrthogonalInSp(1, 4, 8);
gap> TestOrthogonalInSp(-1, 6, 2);
gap> TestOrthogonalInSp(1, 4, 8); # FIXME: `Error, !!!`, see https://github.com/gap-packages/recog/issues/12
gap> TestOrthogonalInSp(-1, 6, 2); # FIXME: `Giving up, Schreier tree is not shallow.`
#@fi
gap> TestOrthogonalInSp(-1, 4, 4);
gap> TestOrthogonalInSp(1, 6, 2);
Expand Down
2 changes: 1 addition & 1 deletion tst/standard/ReducibleMatrixGroups.tst
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ gap> TestOmegaStabilizerOfIsotropicSubspace := function(epsilon, d, q, k)
> CheckSize(G);
> end;;
#@if IsBound(CLASSICAL_MAXIMALS_RUN_BROKEN_TESTS)
gap> TestOmegaStabilizerOfIsotropicSubspace(1, 6, 8, 2);
gap> TestOmegaStabilizerOfIsotropicSubspace(1, 6, 8, 2); # FIXME: `Error, !!!`, see https://github.com/gap-packages/recog/issues/12
#@fi
gap> TestOmegaStabilizerOfIsotropicSubspace(1, 8, 5, 4);
gap> TestOmegaStabilizerOfIsotropicSubspace(0, 5, 7, 2);
Expand Down
2 changes: 1 addition & 1 deletion tst/standard/TensorProductMatrixGroups.tst
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ gap> TestTensorProductStabilizerInSp := function(epsilon, d1, d2, q)
gap> TestTensorProductStabilizerInSp(0, 2, 3, 3);
gap> TestTensorProductStabilizerInSp(0, 4, 3, 5);
#@if IsBound(CLASSICAL_MAXIMALS_RUN_BROKEN_TESTS)
gap> TestTensorProductStabilizerInSp(1, 2, 4, 5);
gap> TestTensorProductStabilizerInSp(1, 2, 4, 5); # FIXME: see https://github.com/gap-packages/recog/issues/316
#@fi
gap> TestTensorProductStabilizerInSp(-1, 2, 4, 5);

Expand Down

0 comments on commit c51e2ad

Please sign in to comment.