Repository navigation
fix: remove unfounded MAX_BONUS clamp from calcBaseStats - #44
Merged
Merged
Conversation
The 60-point cap on trait bonuses has no basis in the game mechanics. The 60 points on the wiki refer to total rank-up growth (10 x 6), while trait bonuses to the four main stats top out around 39. Drop the clamp and the exported MAX_BONUS constant, and cover the unclamped behaviour with a test.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calcBaseStatsclamped trait bonuses toMAX_BONUS = 60. No source supports that cap:Changes
calcBaseStatsnow returnsmainStats - (bonusStats + 6 * rank_ups), which is exactly the wiki formula.MAX_BONUSconstant. This is technically a breaking change to the public API, but no known consumer uses it.Testing
vitest --run: 8 files, 274 tests passingbiome check: clean