Repository navigation
Fix select_for_count for Rails 8.0 with mixed select values - #1
Closed
armellarcier wants to merge 1 commit into
Closed
armellarcier wants to merge 1 commit into
armellarcier wants to merge 1 commit into
Conversation
Add respond_to?(:right) checks before calling .right on select_values to handle both plain strings and Arel nodes. Fixes NoMethodError when calling .count on queries with non-Arel select values in Rails 8.0+. Ref: shioyama#678 Based on: shioyama#679
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add respond_to?(:right) checks before calling .right on select_values to handle both plain strings and Arel nodes. Fixes NoMethodError when calling .count on queries with non-Arel select values in Rails 8.0+.
Ref: shioyama#678
Based on: shioyama#679