Skip to content

Skip dual-energy fix for unphysical results in Hydro_FullStepUpdate() #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsinhaoHHuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip dual-energy fix for unphysical results in Hydro_FullStepUpdate() #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Model_Hydro/CPU_Hydro/CPU_Shared_FullStepUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ void Hydro_FullStepUpdate( const real g_Input[][ CUBE(FLU_NXT) ], real g_Output[
// we no longer apply density and pressure floors here since we want to enable 1st-order-flux correction for that
// Output_1Cell[DENS] = FMAX( Output_1Cell[DENS], MinDens );

// we do not apply the dual-energy fix to the energy
// when the density is negative or Ekin >= 2*Etot (could be caused by an extremely low density)
// --> such that the unphysical energy can be caught by the checks in Flu_Close()->CorrectUnphysical()
const real Ekin = (real)0.5*( SQR(Output_1Cell[MOMX]) + SQR(Output_1Cell[MOMY]) + SQR(Output_1Cell[MOMZ]) )/Output_1Cell[DENS];
const real maxKinOverTot = (real)2.0;
if ( Output_1Cell[DENS] > (real)0.0 && Output_1Cell[ENGY]*maxKinOverTot > Ekin )
Hydro_DualEnergyFix( Output_1Cell[DENS], Output_1Cell[MOMX], Output_1Cell[MOMY], Output_1Cell[MOMZ],
Output_1Cell[ENGY], Output_1Cell[DUAL], g_DE_Status[idx_out],
EoS->AuxArrayDevPtr_Flt[1], EoS->AuxArrayDevPtr_Flt[2], CheckMinPres_No, NULL_REAL,
Expand Down